Config to allow manual toggle #417
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Benchmark
| Benchmark suite | Current: d81f314 | Previous: f249e95 | Ratio |
|---|---|---|---|
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_10 | 18811.29543020142 iter/sec (stddev: 0.000004878258972654655) | 19276.012254694026 iter/sec (stddev: 0.000007194882212445198) | 1.02 |
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_100 | 440.20644009258973 iter/sec (stddev: 0.000051786450044296475) | 458.8171780329479 iter/sec (stddev: 0.00013872918859105467) | 1.04 |
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_1000 | 14.632119878511665 iter/sec (stddev: 0.00024669824224869) | 14.155109168069206 iter/sec (stddev: 0.00026687772628070506) | 0.97 |
tests/node/test_node_benchmark.py::test_node_benchmark_width_2_depth_10 | 89.89122236215945 iter/sec (stddev: 0.00019462364618957813) | 88.85015338115527 iter/sec (stddev: 0.0002954324658704179) | 0.99 |
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_10_no_assertions | 47750.58912225388 iter/sec (stddev: 0.0000021792323881234525) | 26271.12855342515 iter/sec (stddev: 0.000003626467836088443) | 0.55 |
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_10_no_assertions_config | 35300.32635196564 iter/sec (stddev: 0.000011063321988476908) | ||
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_100_no_assertions | 3173.133963211356 iter/sec (stddev: 0.0000026801468321626223) | 2058.0311269153 iter/sec (stddev: 0.000024662611735807703) | 0.65 |
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_100_no_assertions_config | 3154.097038003639 iter/sec (stddev: 0.000014096951500409833) | ||
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_1000_no_assertions | 143.53113327711642 iter/sec (stddev: 0.00456958444745352) | 105.94441112640959 iter/sec (stddev: 0.005267286567033429) | 0.74 |
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_1000_no_assertions_config | 287.0134026792739 iter/sec (stddev: 0.000021778818147881668) | ||
tests/node/test_node_benchmark.py::test_node_benchmark_width_2_depth_10_no_assertions | 211.970967099725 iter/sec (stddev: 0.00017323607022017498) | 126.48484512338128 iter/sec (stddev: 0.000012647594728408522) | 0.60 |
tests/node/test_node_benchmark.py::test_node_benchmark_width_2_depth_10_no_assertions_config | 127.60895796763262 iter/sec (stddev: 0.004312160809550672) |
This comment was automatically generated by workflow using github-action-benchmark.
Contributor
|
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Description
Previously, the flag can only be toggled via env var before import. Now it can be toggled after import as it is a class variable
Testing
Additional notes
Checklist
I have read through the contributing guidelines and ensured that
Checklist (for reviewer)