Remove optional checks, add benchmark timings #411
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
kayjan added documentation 
Contributor
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Benchmark
| Benchmark suite | Current: 688a43d | Previous: 07a7f75 | Ratio |
|---|---|---|---|
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_10 | 18551.80870997438 iter/sec (stddev: 0.000005173758902623608) | 19652.13751341503 iter/sec (stddev: 0.000006059834396773584) | 1.06 |
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_100 | 407.39812174784424 iter/sec (stddev: 0.00009026317057478269) | 408.44228973926033 iter/sec (stddev: 0.0000747082356024446) | 1.00 |
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_1000 | 14.437254577770478 iter/sec (stddev: 0.00031435775460613097) | 14.412968017239987 iter/sec (stddev: 0.0004909369549811161) | 1.00 |
tests/node/test_node_benchmark.py::test_node_benchmark_width_2_depth_10 | 89.51239082879131 iter/sec (stddev: 0.0002368201019309742) | 91.56767895345533 iter/sec (stddev: 0.00027867134814890524) | 1.02 |
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_10_no_assertions | 27031.9219924032 iter/sec (stddev: 0.0000044114977826922815) | 28130.66129474537 iter/sec (stddev: 0.0000035237959360282114) | 1.04 |
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_100_no_assertions | 1871.4204989177076 iter/sec (stddev: 0.000022024042778785036) | 1922.8624499547507 iter/sec (stddev: 0.000018240667955317127) | 1.03 |
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_1000_no_assertions | 101.98439918134474 iter/sec (stddev: 0.0055974193789482315) | 112.5063220115105 iter/sec (stddev: 0.00461836823926094) | 1.10 |
tests/node/test_node_benchmark.py::test_node_benchmark_width_2_depth_10_no_assertions | 130.03496185012995 iter/sec (stddev: 0.00014670400957884794) | 131.82444350919997 iter/sec (stddev: 0.00019229889122942195) | 1.01 |
This comment was automatically generated by workflow using github-action-benchmark.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Description
The following checks will be removed when ASSERTIONS=false (default usage is not changed)
Testing
Additional notes
Checklist
I have read through the contributing guidelines and ensured that
Checklist (for reviewer)