Sync pybind11 with master #3907
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…3898) * removing note in ivector comments and explaining magic constant * Fix some bugs in the online batched cuda ivector code. They are as follows: 1) Striding issue when initializing the gamma stash 2) Rewrote splice kernel. It has small corner case bugs leading to small differences on the boundaries of some chunks. 3) Zero out posteriors for invalid rows. This is necessary because we work with a batch of matrices where each matrix may have different numbers of valid frames. If we don't zero these out X and gamma can have small differences for some gauss points because those invalid posterior rows will add to statistics. Zeroing them out ensures that they don't contribute to the statistics. This now matches to the last siginficant digits across the ivector for multiple datasets: For example: ../ivectorbin/ivector-compute-dot-products trials 'ark:../ivectorbin/ivector-normalize-length --scaleup=false ark:ivector.ark ark:- |' 'ark:../ivectorbin/ivector-normalize-length --scaleup=false ark:ivector-batched.ark ark:- |' scores LOG (ivector-normalize-length[5.5.1697~1-22ac]:main():ivector-normalize-length.cc:90) Processed 80 iVectors. LOG (ivector-normalize-length[5.5.1697~1-22ac]:main():ivector-normalize-length.cc:94) Average ratio of iVector to expected length was 12.214, standard deviation was 7.93438 ../ivectorbin/ivector-normalize-length --scaleup=false ark:ivector-batched.ark ark:- LOG (ivector-normalize-length[5.5.1697~1-22ac]:main():ivector-normalize-length.cc:90) Processed 80 iVectors. LOG (ivector-normalize-length[5.5.1697~1-22ac]:main():ivector-normalize-length.cc:94) Average ratio of iVector to expected length was 12.214, standard deviation was 7.93437 LOG (ivector-compute-dot-products[5.5.1697~1-22ac]:main():ivector-compute-dot-products.cc:108) Mean dot-product was 1, standard deviation was 0 LOG (ivector-compute-dot-products[5.5.1697~1-22ac]:main():ivector-compute-dot-products.cc:111) Processed 80 trials 0 had errors.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
triggered by [src] changes #3898, #3900, #3901, #3903, #3742, #3904, #3905
@danpovey please merge without squash.