[scripts] fix python comp. in librispeech textnorm #3843
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
When using a virtualenv `$PTYHON` points to the system python and not to the python in the virtualenv. Using `python` however points to the virtualenv python (when inside a virtualenv) or the systempython (when not in a virtualenv).
Contributor
| That script hasn't been touched in a long time.. I think your changes are fine, merging. |
wonkyuml pushed a commit to wonkyuml/kaldi that referenced this pull request Jan 16, 2020
Bar-BY pushed a commit to Bar-BY/kaldi that referenced this pull request Jan 21, 2020
galv pushed a commit to galv/kaldi that referenced this pull request Dec 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
During text normalization for librispeech my calculation crashed
because
$PYTHONin normalize_text.sh is calling the systempython and not the python from my virtual enviroment.
Is there any reason to use
$PYTHONand notpython?When inside a virtual env
pythonwill point to this python (and pip packages).When outside a virtual env
pythonwill point to the system python like now.