removed cusolver #3276
Merged
removed cusolver #3276
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Contributor
| Thanks. Ruizhe, please confirm on the CLSP grid that you can run `configure` and compile this with CUDA (e.g. on a 'b' machine). The automated tests will confirm that it runs without CUDA. …On Sat, Apr 27, 2019 at 11:48 AM huangruizhe ***@***.***> wrote: removed cusolver as suggested in #3221 <#3221> ------------------------------ You can view, comment on, or merge this pull request online at: #3276 Commit Summary - removed cusolver File Changes - *M* src/cudamatrix/cu-common.h <https://github.com/kaldi-asr/kaldi/pull/3276/files#diff-0> (9) - *M* src/cudamatrix/cu-device.h <https://github.com/kaldi-asr/kaldi/pull/3276/files#diff-1> (6) - *M* src/makefiles/cuda_64bit.mk <https://github.com/kaldi-asr/kaldi/pull/3276/files#diff-2> (2) Patch Links: - https://github.com/kaldi-asr/kaldi/pull/3276.patch - https://github.com/kaldi-asr/kaldi/pull/3276.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#3276>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAZFLO3H5AGA2FRSKC33JO3PSRYUVANCNFSM4HI4PJEA> . |
Contributor
| Why are we removing cusolver so quickly after adding it? On Sat, Apr 27, 2019 at 8:59 AM Daniel Povey <notifications@github.com> wrote: … Thanks. Ruizhe, please confirm on the CLSP grid that you can run `configure` and compile this with CUDA (e.g. on a 'b' machine). The automated tests will confirm that it runs without CUDA. On Sat, Apr 27, 2019 at 11:48 AM huangruizhe ***@***.***> wrote: > removed cusolver as suggested in #3221 > <#3221> > ------------------------------ > You can view, comment on, or merge this pull request online at: > > #3276 > Commit Summary > > - removed cusolver > > File Changes > > - *M* src/cudamatrix/cu-common.h > <https://github.com/kaldi-asr/kaldi/pull/3276/files#diff-0> (9) > - *M* src/cudamatrix/cu-device.h > <https://github.com/kaldi-asr/kaldi/pull/3276/files#diff-1> (6) > - *M* src/makefiles/cuda_64bit.mk > <https://github.com/kaldi-asr/kaldi/pull/3276/files#diff-2> (2) > > Patch Links: > > - https://github.com/kaldi-asr/kaldi/pull/3276.patch > - https://github.com/kaldi-asr/kaldi/pull/3276.diff > > — > You are receiving this because you are subscribed to this thread. > Reply to this email directly, view it on GitHub > <#3276>, or mute the thread > < https://github.com/notifications/unsubscribe-auth/AAZFLO3H5AGA2FRSKC33JO3PSRYUVANCNFSM4HI4PJEA > > . > — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#3276 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABEL6UACOX7Q3KXVPTCEJNTPSRZ5ZANCNFSM4HI4PJEA> . -- Daniel Galvez http://danielgalvez.me https://github.com/galv |
Contributor
| It's not actually needed for anything right now (Justin added it in anticipation of using it later), and it causes a build problem with CUDA toolkits pre-9.1; solving it would require bumping the configure version which I don't think is warranted. There was a discussion on kaldi-help. |
Contributor
| Okay, thanks …On Sat, Apr 27, 2019 at 9:11 AM Daniel Povey ***@***.***> wrote: It's not actually needed for anything right now (Justin added it in anticipation of using it later), and it causes a build problem with CUDA toolkits pre-9.1; solving it would require bumping the configure version which I don't think is warranted. There was a discussion on kaldi-help. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#3276 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABEL6UEACINVG5IM6CSCU3TPSR3M3ANCNFSM4HI4PJEA> . -- Daniel Galvez http://danielgalvez.me https://github.com/galv |
Contributor Author
| It compiles (from scratch, e.g. make clean) correctly on the grid (b16). |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
removed cusolver as suggested in #3221