Fixes to chain and relevant nnet3 python scripts to support python3.x #2629
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
added 2 commits August 17, 2018 15:37
Details: 1. thread module has been renamed to _thread from python3 https://docs.python.org/2/library/thread.html ``` Python 3.4.8 (default, Mar 23 2018, 10:04:27) Type 'copyright', 'credits' or 'license' for more information IPython 6.4.0 -- An enhanced Interactive Python. Type '?' for help. In [1]: import thread --------------------------------------------------------------------------- ImportError Traceback (most recent call last) <ipython-input-1-e75c663b2a08> in <module>() ----> 1 import thread ImportError: No module named 'thread' ``` 2. any division operation results in float by default ``` Python 3.6.3 (default, Jan 4 2018, 16:40:53) Type 'copyright', 'credits' or 'license' for more information IPython 6.5.0 -- An enhanced Interactive Python. Type '?' for help. In [1]: 32/2 Out[1]: 16.0 In [2]: int(32)/2 Out[2]: 16.0 In [3]: int(int(32)/2) Out[3]: 16 In [5]: 16/4 % 3 Out[5]: 1.0 ```
danpovey reviewed Aug 17, 2018
| # previous : frame_shift = (k/num_archives) % frame_subsampling_factor | ||
| frame_shift = ((archive_index + k/num_archives) | ||
| % frame_subsampling_factor) | ||
| frame_shift = int((archive_index + k/num_archives) |
Contributor
There was a problem hiding this comment.
thanks. I think a better fix here would be to write k // num_archives. Same for the other place-- change / to //.
dpriver pushed a commit to dpriver/kaldi that referenced this pull request Sep 13, 2018
Skaiste pushed a commit to Skaiste/idlak that referenced this pull request Sep 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Details:
https://docs.python.org/2/library/thread.html