Preserve the comments in STM file on subsetting data directory #2627
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
danpovey reviewed Aug 17, 2018
egs/wsj/s5/utils/subset_data_dir.sh Outdated
| [ -f $srcdir/stm ] && utils/filter_scp.pl $destdir/reco < $srcdir/stm > $destdir/stm | ||
| # Filter the STM file for proper sclite scoring | ||
| # Copy over the comments from STM file | ||
| [-f $srcdir/stm ] && grep ";;" $srcdir/stm > ${destdir}/stm |
Contributor
There was a problem hiding this comment.
this would be a command not found; need space. Test before making PR!
But thanks.
Contributor Author
There was a problem hiding this comment.
Apologies... fixed...
danpovey reviewed Aug 17, 2018
egs/wsj/s5/utils/subset_data_dir.sh Outdated
| [ -f $srcdir/stm ] && utils/filter_scp.pl $destdir/reco < $srcdir/stm > $destdir/stm | ||
| # Filter the STM file for proper sclite scoring | ||
| # Copy over the comments from STM file | ||
| [ -f $srcdir/stm ] && grep ";;" $srcdir/stm > ${destdir}/stm |
Contributor
There was a problem hiding this comment.
I think better to use '^;;' as the pattern, to avoid over-matching.
Contributor Author
| @danpovey Addressed your comments. |
danpovey reviewed Aug 18, 2018
egs/wsj/s5/utils/subset_data_dir.sh Outdated
| [ -f $srcdir/stm ] && utils/filter_scp.pl $destdir/reco < $srcdir/stm > $destdir/stm | ||
| # Filter the STM file for proper sclite scoring | ||
| # Copy over the comments from STM file | ||
| [ -f $srcdir/stm ] && grep "^;;" $srcdir/stm > ${destdir}/stm |
Contributor
There was a problem hiding this comment.
can you remove the curly braces from destdir? It's just inconsistent-looking.
dpriver pushed a commit to dpriver/kaldi that referenced this pull request Sep 13, 2018
Skaiste pushed a commit to Skaiste/idlak that referenced this pull request Sep 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Addresses #1765