small improvement over pruned lattice-rescoring algorithm #2504
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
danpovey reviewed Jun 15, 2018
Contributor
danpovey left a comment
danpovey left a comment There was a problem hiding this comment.
thanks. A couple small comments.
| int32 lm_state; | ||
| | ||
| // the distance between the state from the start state | ||
| int32 depth; |
Contributor
There was a problem hiding this comment.
it might be more accurate to describe this as:
the number of arcs on the path from the start state to this state, in the composed lattice, by which this state was first reached. src/lat/compose-lattice-pruned.cc Outdated
| // in a depth-first way. Once we find a path reaching a final state, this | ||
| // variable will be reset to 0. | ||
| // The reason we do this is because the beam-search depends on a good estimate | ||
| // of the composed-best-cost, which before we reach a fina state, we instead |
dpriver pushed a commit to dpriver/kaldi that referenced this pull request Sep 13, 2018
Skaiste pushed a commit to Skaiste/idlak that referenced this pull request Sep 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This was first tested on the material recipe, and also on swbd. It was giving the almost identical performance as before but faster.