Fix None arg in pad segments #2470
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
danpovey reviewed Jun 1, 2018
| """Pads segments by duration 'segment_padding' on either sides, but | ||
| ensures that the segments don't go beyond the neighboring segments | ||
| or the duration of the utterance 'max_duration'.""" | ||
| if max_duration == None: |
dpriver pushed a commit to dpriver/kaldi that referenced this pull request Sep 13, 2018
Skaiste pushed a commit to Skaiste/idlak that referenced this pull request Sep 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
pad_speech_segmentsis called inkaldi/egs/wsj/s5/steps/segmentation/internal/sad_to_segments.py
Lines 236 to 238 in fd545bb
max_durationmight get set toNone. This doesn't fall back on the default value, and causes a type error atkaldi/egs/wsj/s5/steps/segmentation/internal/sad_to_segments.py
Line 186 in fd545bb