Skip to content

Conversation

@huangruizhe
Copy link
Contributor

Remove un-needed files, which are not mentioned in any Makefile or not included in any other src files.

First, in kaldi/src/ directory and its subdirectories, the following shell script finds out all candidates which are *.cc or *.h files whose basic file names (without the extension) are not mentioned in any of the following:

  • Makefile*
  • *.mk
  • kaldi/src/configure

find-non-used.txt (change extention to .sh and chmod+x before use)

Here are 6 files we found:

  • src/chain/context-dep-topology.h
  • src/cudamatrix/cu-kernels-ansi.h ----x
  • src/decoder/decodable-mapped.h
  • src/decoder/decodable-sum.h
  • src/util/basic-filebuf.h ----x
  • src/util/kaldi-cygwin-io-inl.h ----x

Second, we use the following script to double-check the candidates and see if they are referenced by others but not explicitly mentioned in Makefiles:
grep -r base_name kaldi/src/
The "false-positives" are those marked by "----x".

At last, we remove the remaining 3 files.

@danpovey
Copy link
Contributor

danpovey commented May 2, 2018

Thanks for finding these.
Please update your PR to un-delete the two decodable headers. They may be useful for something in future, and may possibly be used by people already for things like system combination.

@huangruizhe
Copy link
Contributor Author

huangruizhe commented May 3, 2018

The two decodable headers are un-deleted, while their version histories are preserved.

@danpovey danpovey merged commit 20b2a45 into kaldi-asr:master May 3, 2018
@huangruizhe huangruizhe deleted the dev branch May 3, 2018 23:23
dpriver pushed a commit to dpriver/kaldi that referenced this pull request Sep 13, 2018
Skaiste pushed a commit to Skaiste/idlak that referenced this pull request Sep 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants