[scripts] Fix for nnet3 model combination on CPU when --use-gpu false #2240
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Contributor
| is this tested now? |
Contributor
| Looks like it's tested. Merging. |
Contributor Author
| My apologies for not replying sooner. It took some time to create a test setup and have it run on CPUs (while using Kaldi compiled with CUDA enabled). It's running now (chain TDNN model training), so far it's working as intended. |
LvHang pushed a commit to LvHang/kaldi that referenced this pull request Apr 14, 2018
…kaldi-asr#2240) Conflicts: egs/wsj/s5/steps/nnet3/train_raw_rnn.py
Skaiste pushed a commit to Skaiste/idlak that referenced this pull request Sep 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This fix passes
--use-gpu=notonnet3-combineandnnet3-chain-combinewhen--use-gpuis set tofalsein any of the python training scripts (train.py/train_dnn.py/train_rnn.py/train_raw_dnn.py/train_raw_rnn.py).WARNING: I have not tested this fix yet (and probably won't be able to test it for all possible training scripts, as I don't have setups ready to run). Perhaps someone else can help with testing (though, not many people train on CPUs). While the changes seem relatively straightforward, there may be cases that I missed.