Minor change to cudamatrix - cu-sparse-matrix.cc #2077
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
danpovey reviewed Dec 11, 2017
src/cudamatrix/cu-sparse-matrix.cc Outdated
| CuTimer tim; | ||
| | ||
| CUSPARSE_SAFE_CALL( | ||
| CU_SAFE_CALL( |
Contributor
There was a problem hiding this comment.
Looks to me like there was a merge problem here. It should be CUSPARSE_SAFE_CALL
Contributor Author
There was a problem hiding this comment.
Fixed it, thanks.
kronos-cm added a commit to kronos-cm/kaldi that referenced this pull request Dec 18, 2017
* 'master' of https://github.com/kaldi-asr/kaldi: (58 commits) [src] Fix bug in nnet3 optimization, affecting Scale() operation; cosmetic fixes. (kaldi-asr#2088) [egs] Mac compatibility fix to SGMM+MMI: remove -T option to cp (kaldi-asr#2087) [egs] Copy dictionary-preparation-script fix from fisher-english(8e7793f) to fisher-swbd and ami (kaldi-asr#2084) [egs] Small fix to backstitch in AMI scripts (kaldi-asr#2083) [scripts] Fix augment_data_dir.py (relates to non-pipe case of wav.scp) (kaldi-asr#2081) [egs,scripts] Add OPGRU scripts and recipes (kaldi-asr#1950) [egs] Add an l2-regularize-based recipe for image recognition setups (kaldi-asr#2066) [src] Bug-fix to assertion in cu-sparse-matrix.cc (RE large matrices) (kaldi-asr#2077) [egs] Add a tdnn+lstm+attention+backstitch recipe for tedlium (kaldi-asr#1982) [src,egs] Small cosmetic fixes (kaldi-asr#2074) [src] Small fix RE CuSparse error code printing (kaldi-asr#2070) [src] Fix compilation error on MSVC: missing include. (kaldi-asr#2064) [egs] Update to CSJ example scripts, with chain+TDNN recipes. Thanks: @rickychanhoyin (kaldi-asr#2035) [scripts,egs] Convert ". path.sh" to ". ./path.sh" (kaldi-asr#2061) [doc] Add documentation about matrix row and column ranges in scp files. [egs] Add recipe for Mozilla Common Voice corpus v1 (kaldi-asr#2057) [scripts] Fix bug in slurm.pl affecting log format (kaldi-asr#2063) [src] Fix some small typos (kaldi-asr#2060) [scripts] Adding --num-threads option to ivector extraction scripts; script fixes (kaldi-asr#2055) [src] Bug-fix to conceptual bug in Minimum Bayes Risk/sausage code. Thanks:@jtrmal (kaldi-asr#2056) ...
mahsa7823 pushed a commit to mahsa7823/kaldi that referenced this pull request Feb 28, 2018
Skaiste pushed a commit to Skaiste/idlak that referenced this pull request Sep 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
As discussed in issue #2068 .
Large vocabularies caused int32 overflow issues in matrix creation.
Solution proposed by @danpovey: cast num_cols to int64 to prevent it.
The use of a large vocabulary may still cause memory issues.