Skip to content

From discussion in PR #2046 #2047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 29, 2017
Merged

From discussion in PR #2046 #2047

merged 4 commits into from
Nov 29, 2017

Conversation

@sdrobert
Copy link
Contributor

@sdrobert sdrobert commented Nov 29, 2017

This PR contains 4 commits:

  1. Reverts PR TokenHolder warns on failed read; print only printable buffer #2044.
  2. Replaces KALDI_ERR with KALDI_WARN in TokenHolder::Read
  3. Encapsulates character output in ReadToken with CharToString
  4. Truncates "actual" token and line output in Matrix::Read and Vector::Read to 20 characters w/ ellipses when past 20 chars.
@danpovey
Copy link
Contributor

danpovey commented Nov 29, 2017

Thanks! Merging.
@danpovey danpovey merged commit 35288fa into kaldi-asr:master Nov 29, 2017
mahsa7823 pushed a commit to mahsa7823/kaldi that referenced this pull request Feb 28, 2018
@sdrobert
[src] Mostly cosmetic changes in error handling (kaldi-asr#2047)
d4de55a
Skaiste pushed a commit to Skaiste/idlak that referenced this pull request Sep 26, 2018
@sdrobert @danpovey
[src] Mostly cosmetic changes in error handling (kaldi-asr#2047)
41f237b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@sdrobert @danpovey