Remove download of ATLAS header files from tools/. #1974
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Commit the header files cblas.h and clapack.h from ATLAS directly instead for simplicity. Use a new directory for the atlas header files. This way, when people pull this commit from github, they won't get an error from git saying that the pull will overwrite untracked files (namely, clapack.h and cblas.h). Also remove custom installation of ATLAS from tools/ since it's rarely used and apparently broken at the moment.
Contributor Author
| I don't fully justify myself in the commit message, but I anticipate this to be 100% backwards compatible. Let me know if you have any concerns. |
Contributor
| I am testing right now, I hope to commit soon. …On Wed, Oct 25, 2017 at 10:25 PM, Daniel Galvez ***@***.***> wrote: I don't fully justify myself in the commit message, but I anticipate this to be 100% backwards compatible. Let me know if you have any concerns. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#1974 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADJVu7agoBJIKMHBZc1Er1mneldbDZiHks5sv-2ggaJpZM4QG6h1> . |
kronos-cm added a commit to kronos-cm/kaldi that referenced this pull request Nov 4, 2017
* 'master' of https://github.com/kaldi-asr/kaldi: [src,scripts] nnet1-related changes: (kaldi-asr#1998) [egs] rotation for image augmentation in CIFAR example (kaldi-asr#1955) [egs] Minor fixes to the SRE16 v2 recipe (kaldi-asr#1986) [egs] Remove deprecated non-working scripts [scripts] Fixes to segment_long_utterances.sh (thanks @christophfeinauer) and train_raw_dnn.py (kaldi-asr#1993) [src] Minor fix: change to error message (kaldi-asr#1980) [egs] Add example of component-level l2-regularize for WSJ scripts [egs] Small fix to Chime4 RE data location (kaldi-asr#1966) [build] Remove download of ATLAS header files from tools/. (kaldi-asr#1974)
xiaohui-zhang pushed a commit to xiaohui-zhang/kaldi that referenced this pull request Nov 14, 2017
…#1974) Commit the header files cblas.h and clapack.h from ATLAS directly instead for simplicity. Use a new directory for the atlas header files. This way, when people pull this commit from github, they won't get an error from git saying that the pull will overwrite untracked files (namely, clapack.h and cblas.h). Also remove custom installation of ATLAS from tools/ since it's rarely used and apparently broken at the moment.
mahsa7823 pushed a commit to mahsa7823/kaldi that referenced this pull request Feb 28, 2018
…#1974) Commit the header files cblas.h and clapack.h from ATLAS directly instead for simplicity. Use a new directory for the atlas header files. This way, when people pull this commit from github, they won't get an error from git saying that the pull will overwrite untracked files (namely, clapack.h and cblas.h). Also remove custom installation of ATLAS from tools/ since it's rarely used and apparently broken at the moment.
Skaiste pushed a commit to Skaiste/idlak that referenced this pull request Sep 26, 2018
…#1974) Commit the header files cblas.h and clapack.h from ATLAS directly instead for simplicity. Use a new directory for the atlas header files. This way, when people pull this commit from github, they won't get an error from git saying that the pull will overwrite untracked files (namely, clapack.h and cblas.h). Also remove custom installation of ATLAS from tools/ since it's rarely used and apparently broken at the moment.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Commit the header files cblas.h and clapack.h from ATLAS directly
instead for simplicity.
Use a new directory for the atlas header files. This way, when people
pull this commit from github, they won't get an error from git saying
that the pull will overwrite untracked files (namely, clapack.h and
cblas.h).
Also remove custom installation of ATLAS from tools/ since it's rarely
used and apparently broken at the moment.