Replaced all sed commands using \t and \n with perl commands for OS X… #1935
Conversation
… compatiblity issues.
danpovey left a comment
danpovey left a comment There was a problem hiding this comment.
I haven't gone through all of this... let me see how you respond to these issues... see if you can apply these comments as globally as possible.
| paste \ | ||
| <(cat $lexicon | awk '{print $1}' | uconv -f $encoding -t $encoding -x "$icu_transform") \ | ||
| <(cat $lexicon | sed $'s/^[^ \t][^ \t]*[ \t]//g') \ | ||
| <(cat $lexicon | perl -ape 's/^[^ \t][^ \t]*[ \t]//g;') \ |
There was a problem hiding this comment.
because this regex is more complicated you should check with some example input that it does what you think it does (different progrmas have different conventions).
| tab=$'\t' | ||
| ls -1 $wav_train/id$sid/*.wav \ | ||
| | sed "s/\(.*\)\/\(.*\).wav/${sid2}_\2${tab}\1\/\2.wav/" \ | ||
| | perl -ape "s/(.*)\/(.*).wav/${sid2}_\2\t\1\/\2.wav/;" \ |
There was a problem hiding this comment.
You can't assume that these advanced features are compatible; you'll have to test it. I suggest to just figure out a single line that you think should probably match, and try both versions. However, in this particular case you could probably leave the sed there. It's the newline which we really have a problem with, the tab can be dealt with using the existing solution.
There was a problem hiding this comment.
yep that's what I did regarding tests. Do you still want to switch back to our old solution using sed?
| tab=$'\t' | ||
| ls -1 $wav_dir/*/s${sid}_*.wav \ | ||
| | sed "s/\(.*\)\/\(.*\)\/s.*_\(.*\).wav/${sid2}_\3_\2${tab}\1\/\2\/s${sid}_\3.wav/" \ | ||
| | perl -ape "s/(.*)\/(.*)\/s.*_(.*).wav/${sid2}_\3_\2$\t\1\/\2\/s${sid}_\3.wav/;" \ |
There was a problem hiding this comment.
again, for complex things like this you should either test somehow, or leave the sed command.
There was a problem hiding this comment.
yep. I actually tested every complex perl command I wrote... The major feature not compatible I've encountered that is that "(" is already a special symbol in perl so we don't need the backslash before it.
2 participants
… compatiblity issues.