[scripts] Added a dollar sign before sed commmands when it uses \t, to force us… #1928
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…ing bash's string syntax, since OS X sed doesn't recognize \t as a tab.
danpovey reviewed Oct 10, 2017
| sid2=`printf "s%02d" $sid` | ||
| ls -1 $wav_train/id$sid/*.wav \ | ||
| | sed "s/\(.*\)\/\(.*\).wav/${sid2}_\2\t\1\/\2.wav/" \ | ||
| | sed $"s/\(.*\)\/\(.*\).wav/${sid2}_\2\t\1\/\2.wav/" \ |
Contributor
There was a problem hiding this comment.
this is not right: the dollar sign syntax doesn't work with double-quotes, and with single-quotes the backslash-then-digit things won't work right. I suggest to do
tab=$'\t'
and then use $tab instead of \t.
Contributor Author
| fixed. thanks |
danpovey reviewed Oct 10, 2017
| # Create utt2spk files | ||
| # No speaker ID | ||
| sed 's/\(.*\)\t.*/\1\t\1/' < "$scp" > "$data/$x/utt2spk" | ||
| sed $'s/\(.*\)\t.*/\1\t\1/' < "$scp" > "$data/$x/utt2spk" |
Contributor
There was a problem hiding this comment.
this won't work, the backslash-1 disappears.
danpovey reviewed Oct 11, 2017
| # No speaker ID | ||
| sed 's/\(.*\)\t.*/\1\t\1/' < "$scp" > "$data/$x/utt2spk" | ||
| tab=$'\t' | ||
| sed "s/\(.*\)\t.*/\1${tab}\1/" < "$scp" > "$data/$x/utt2spk" |
danpovey reviewed Oct 11, 2017
| # Use speaker ID | ||
| #sed "s/\(s..\)\(.*\)\t.*/\1\2\t\1/" < "$scp" > "$data/$x/utt2spk" | ||
| # tab=$'\t' | ||
| # sed "s/\(s..\)\(.*\)\t.*/\1\2${tab}\1/" < "$scp" > "$data/$x/utt2spk" |
Contributor
There was a problem hiding this comment.
better fix this one too although it's commented.
Contributor
| Thanks! merging. |
Skaiste pushed a commit to Skaiste/idlak that referenced this pull request Sep 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
…ing bash's string syntax, since OS X sed doesn't recognize \t as a tab.