Skip to content

Conversation

@selaselah
Copy link
Contributor

all CuBLAS func return a cublasStatus_t, which is not same as cudaError_t and the value mean is not compatible

dimGrid->z = 1;
}

const char* cublasGetStatusString(cublasStatus_t status)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the PR.
So there wasn't an official version of this function, that we could have used?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that there wasn't an official function like this, but please use Google style w.r.t. open-braces: put them on the same line as the previous one, after a space, e.g.
const char* cublasGetStatusString(cublasStatus_t status) {

And please put a comment before the declaration of this function, saying:
// This is analogous to the CUDA function cudaGetErrorString().

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reformat done.
Howerver, the CI raise some reasonless error :(

@selaselah selaselah closed this Sep 22, 2017
@selaselah selaselah reopened this Sep 22, 2017
@selaselah selaselah closed this Sep 22, 2017
@selaselah selaselah reopened this Sep 22, 2017
@selaselah selaselah closed this Sep 22, 2017
@selaselah selaselah reopened this Sep 22, 2017
@selaselah
Copy link
Contributor Author

the CI failed randomly. I have reopened this request several times but all are failed. Here is some error log:

ln: failed to create symbolic link ‘/home/travis/build/kaldi-asr/kaldi/src/lib/libkaldi-matrix.so’: File exists 
@selaselah selaselah closed this Sep 22, 2017
@selaselah selaselah reopened this Sep 22, 2017
@danpovey
Copy link
Contributor

danpovey commented Sep 22, 2017 via email

@danpovey danpovey merged commit 633310c into kaldi-asr:master Sep 22, 2017
@jtrmal
Copy link
Contributor

jtrmal commented Sep 22, 2017 via email

@danpovey
Copy link
Contributor

We have some CuSparse library calls in the 'rnnlm' branch and I think the same issue exists there. Do you have time to address that via another PR?

@selaselah
Copy link
Contributor Author

I check the CuSparse's doc,. The status value also conflict with cudaError_t. I'll take a PR tomorrow.

@selaselah selaselah deleted the chendx-fix-cu-safe-call branch September 24, 2017 14:58
Skaiste pushed a commit to Skaiste/idlak that referenced this pull request Sep 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants