Skip to content

Conversation

@jtrmal
Copy link
Contributor

@jtrmal jtrmal commented Jul 31, 2017

VS 2017 have a problem figuring that KwsLexicographicArc typedef'd as Arc is actually correct. This looks like the simplest and nicest fix

@danpovey
Copy link
Contributor

I'll merge. Who was looking after the travis? We might have to tune it again.
Some of the tests appear to take many minutes, but when run locally take a fraction of a second...those tests create temporary files, and I wonder whether some file system weirdness or latency on Travis is the cause. Perhaps reducing the num-jobs (-p) in the Makefile would help? I don't know when we last tuned this.

@danpovey danpovey merged commit af4b687 into kaldi-asr:master Jul 31, 2017
@jtrmal
Copy link
Contributor Author

jtrmal commented Aug 1, 2017 via email

@dogancan
Copy link
Contributor

dogancan commented Aug 1, 2017

Unfortunately I don't have time at the moment. We last tuned Travis when switching to c++11. At the time g++ was significantly slower, so we switched to clang-3.8. I think we also increased the number of parallel jobs since clang was using less memory and we could get faster builds that way.

@kkm000
Copy link
Contributor

kkm000 commented Aug 4, 2017 via email

kronos-cm added a commit to kronos-cm/kaldi that referenced this pull request Aug 5, 2017
* 'master' of https://github.com/kaldi-asr/kaldi: [egs] Update tedlium and aspire recipes to use xconfigs (avoid crash) (kaldi-asr#1790) [egs] fix bugs in Multi-database English LVCSR recipe (kaldi-asr#1785) [src,egs,scripts] Cosmetic and other minor fixes, some required for segmentation PR (kaldi-asr#1784) [egs] update multi_condition script in swbd (kaldi-asr#1788) [src] Circumvent Visual Studio 2017 bug regarding name resolution (kaldi-asr#1783) [tools] adding phonetisaurus install scripts (PR#1734) [scripts] update nnet3 scripts to fix bug where rejecting 'bad' models was not happening (kaldi-asr#1777) [src] make dithering in feature processing more efficient by using random state, thanks: liximin244@gmail.com
@kkm000
Copy link
Contributor

kkm000 commented Aug 7, 2017

I'll see how far we can get with ccache--travis seem to have added the support for keeping caches between builds.

@jtrmal
Copy link
Contributor Author

jtrmal commented Aug 7, 2017 via email

@jtrmal jtrmal deleted the win-fix-compile branch November 20, 2017 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants