added new ComputeFeatures function and modified binaries to allow do… #1773
Conversation
…wnsampling waveform(waveform downsampling function is not added yet).
| @danpovey |
danpovey left a comment
danpovey left a comment There was a problem hiding this comment.
Some small comments (and suggestions Re how to do the downsampling)
src/feat/feature-common.h Outdated
| be 1.0) | ||
| @param [out] output The matrix of features, where the row-index | ||
| is the frame index. | ||
| of the input waveform. | ||
| @param [in] wave The input waveform | ||
| @param [in] sample_freq The sampling frequency with which | ||
| 'wave' was sampled. |
There was a problem hiding this comment.
clarify that if sample_freq is higher than the frequency specified in the config,
we'll downsample, but if lower, it's an error.
src/feat/feature-window.h Outdated
| blackman_coeff(0.42), | ||
| snip_edges(true){ } | ||
| snip_edges(true), | ||
| allow_downsample(false){ } |
There was a problem hiding this comment.
space after ) [this was wrong in the original code]
| << sample_freq << " .vs " << new_sample_freq | ||
| << "--allow_downsample should be true to allow " | ||
| << " downsampling the waveform."; | ||
| |
There was a problem hiding this comment.
OK, so I guess this is where you'd call the 'real' downsample function.
Declare it in resample.h, and maybe make it something like:
/// Downsample a waveform. This is a convenience wrapper for the /// class 'LinearResample'. void DownsampleWaveform(BaseFloat orig_freq, const VectorBase<BaseFloat> &wave, BaseFloat new_freq, Vector<BaseFloat> *new_wave); Regarding the filter-cutoff, please find out what sox uses and use that rule to find it;
and document it in the declaration of the function. For 'num_zeros', maybe use 10.
| << spec_opts.frame_opts.samp_freq << " but data has " | ||
| << wave_data.SampFreq() << " (use --sample-frequency " | ||
| << "option). Utterance is " << utt; | ||
| << spec_opts.frame_opts.samp_freq << " larger than data sample freq " |
There was a problem hiding this comment.
You can remove this check, it's checked internally.
* 'master' of https://github.com/kaldi-asr/kaldi: [scripts] reverting the recent change of perturb_data_dir_speed_3way.sh (kaldi-asr#1809) [src] modify feature-extraction binaries to support downsampling (kaldi-asr#1773) [src] Small test-code fix [src] Fix bug in model-update consolidation code (thanks: sriram ganapathy).
2 participants
…wnsampling waveform(waveform downsampling function is not added yet).