missing make_corpus_subset.sh #1766
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Contributor
| @jtrmal, can you look at this? |
Contributor
| Ok. Will do. Y. …On Jul 16, 2017 9:10 PM, "Daniel Povey" ***@***.***> wrote: @jtrmal <https://github.com/jtrmal>, can you look at this? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1766 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AKisXzKlL1ywRteAoRICC3Kg46IkYvENks5sOmAHgaJpZM4OY5Be> . |
jtrmal reviewed Jul 17, 2017
| # Get the alignments as lattices (gives the chain training more freedom). | ||
| # use the same num-jobs as the alignments | ||
| steps/align_fmllr_lats.sh --nj 100 --cmd "$train_cmd" ${lores_train_data_dir} \ | ||
| steps/align_fmllr_lats.sh --nj $nj --cmd "$train_cmd" ${lores_train_data_dir} \ |
Contributor
There was a problem hiding this comment.
@danpovey @johnjosephmorgan I know there was a conversation on this and I think at the end the sentiment was to leave 100 here?
Contributor
| I think it's pretty harmless when you do squash-n-merge (after addressing the $nj vs 100). It has a lot of revisions because John didn't based it on the current head. |
Contributor
| Yes, leave 100. …On Mon, Jul 17, 2017 at 12:28 PM, jtrmal ***@***.***> wrote: I think it's pretty harmless when you do squash-n-merge (after addressing the $nj vs 100). It has a lot of revisions because John didn't based it on the current head. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1766 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADJVu6G7ywm6O2oKs7z5uDRXCnsFJcPJks5sO4qbgaJpZM4OY5Be> . |
Contributor
| @johnjosephmorgan, can you change the --nj $nj back to --nj 100? |
kronos-cm added a commit to kronos-cm/kaldi that referenced this pull request Jul 25, 2017
* 'master' of https://github.com/kaldi-asr/kaldi: (36 commits) [scripts] Fix convert_nnet2_to_nnet3.py (kaldi-asr#1774) [egs] Add missing make_corpus_subset.sh in babel_multilang example (kaldi-asr#1766) [egs] Graphemic lexicon updates / fixes in babel/s5d recipe and hub4_spanish recipe (kaldi-asr#1740) [egs] update hkust results (kaldi-asr#1772) [egs] Update AMI chain experiments RE dropout, decay-time and proportional-shrink (kaldi-asr#1732) [egs] Fixes to the aishell (Mandarin) recipe (kaldi-asr#1770) [egs] Add recipe for aishell data (free Mandarin corpus, 170 hours total) (kaldi-asr#1742) [src] Change to arpa-reading code to accept blank lines with whitespace (kaldi-asr#1752) [scripts] For nnet3 training, add option to disable the model-combination (kaldi-asr#1757) [scripts] minor bugfix to nnet1 alignment script when creating lattices (kaldi-asr#1764) [src] Add support for row/column ranges when reading GeneralMatrix (kaldi-asr#1761) [src] Change name of option --norm-mean->--norm-means for consistency, thanks: 415198468@qq.com [egs] swbd/s5c, added 5 layer (b)lstm recipes (kaldi-asr#1759) [scripts] Fix bug in segment_long_utterances.sh (kaldi-asr#1758) [src] Fix indexing error in nnet1::Convolutional2DComponent (kaldi-asr#1755) [src] Fix usage message of program (thanks:jubang0219@gmail.com) [egs] some small updates to scripts (installing beamformit; segmentation example) [egs] Small fix to ami/s5b/local/chain/compare_wer_general.sh (kaldi-asr#1751) [build] Add configuration check for incompatible g++ compilers when CUDA is enabled. (kaldi-asr#1749) [egs] Update Librispeech nnet3 TDNN recipe (old one did not run) (kaldi-asr#1727) ...
Skaiste pushed a commit to Skaiste/idlak that referenced this pull request Sep 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
The run-4-anydecod-langs.sh script calls local/make_corpus_subset.sh, but this script is not there. I copied the script from babel/s5d.