sequitur: try to work out the correct compilation flags #1716
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
jtrmal force-pushed the fix_macosx_sequitur branch from de0de0f to 2fbe158 Compare 
jtrmal force-pushed the fix_macosx_sequitur branch from 2fbe158 to bef53e3 Compare jtrmal changed the title 
Contributor Author
| @danpovey I didn't head from that guy, but I think this is a safe change w.r.t. linux, sounless you object, please merge. Or we can drop it, as we didn't have any more reports on issues about this. |
Contributor
| Can you see why the check failed? It looks like it's not finding src/base/version.h. Could it be a problem with the recent changes to the travis setup? |
Contributor Author
| @kkm000 added some code that prints additional info after a run (and the version is one of those info) but the file won't get created when there was only a change outside src/ (when we were starting with travis, we decided not to compile everything if there was only a change in egs and/or tools) |
Contributor
| Hm, OK. I guess that needs to be fixed somehow? Because it caused the build to fail. …On Thu, Aug 17, 2017 at 8:23 AM, jtrmal ***@***.***> wrote: @kkm000 <https://github.com/kkm000> added some code that prints additional info after a run (and the version is one of those info) but the file won't get created when there was only a change outside src/ (when we were starting with travis, we decided not to compile everything if there was only a change in egs and/or tools) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1716 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADJVuy8KwkFwEE6lKmHP8OFwUZqii_0Wks5sZFXggaJpZM4OGQ9p> . |
Contributor Author
| Hopefully will be addressed by #1827 (I'll restart build of this if/when the fix gets merged). |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
should be resolving #1107