tools: remove openfst check

[KarelVesely84]

• we will use the local open-fst, while we still can have the system-wide open-fst (not used by kaldi)
• (note: this setup was previously forbidden)

[KarelVesely84]

I better double-checked that this will cause no problems...
In `kaldi.mk' there are the absolute paths to the local OpenFST:

OPENFSTINC = /mnt/matylda5/iveselyk/DEVEL/kaldi-official/tools/openfst/include
OPENFSTLIBS = /mnt/matylda5/iveselyk/DEVEL/kaldi-official/tools/openfst/lib/libfst.so
OPENFSTLDFLAGS = -Wl,-rpath=/mnt/matylda5/iveselyk/DEVEL/kaldi-official/tools/openfst/lib

The headers are okay, as the '-I${OPENFSTINC}' option has priority over the system includes.
The library is also okay, as the LD_LIBRARY_PATH is stored directly to the binary with the '-rpath' option,
and we provied absolute path to the linker.

The related documentation is here:

Headers [4th paragraph]: https://gcc.gnu.org/onlinedocs/cpp/Search-Path.html#Search-Path
Library [section 3.4]: http://tldp.org/HOWTO/Program-Library-HOWTO/shared-libraries.html

[danpovey]

But I believe the OpenFst headers would be installed to a system location, and system-level includes always take precedence over local ones.

…

On Tue, Apr 4, 2017 at 8:06 AM, Karel Vesely ***@***.***> wrote: I better double-checked that this causes no problems... In `kaldi.mk' there are the absolute paths to the local OpenFST: OPENFSTINC = /mnt/matylda5/iveselyk/DEVEL/kaldi-official/tools/openfst/ include OPENFSTLIBS = /mnt/matylda5/iveselyk/DEVEL/kaldi-official/tools/openfst/ lib/libfst.so OPENFSTLDFLAGS = -Wl,-rpath=/mnt/matylda5/iveselyk/DEVEL/kaldi-official/ tools/openfst/lib The headers are okay, as the '-I${OPENFSTINC}' option has priority over the system dirs. The library is also okay, as the LD_LIBRARY_PATH is stored to the binary by the '-rpath' options. The related documentation is here: Headers [4th paragraph]: https://gcc.gnu.org/onlinedocs/cpp/Search-Path. html#Search-Path Library [section 3.4]: http://tldp.org/HOWTO/Program-Library-HOWTO/shared- libraries.html — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#1531 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADJVu22E7oY0_JNZLVOp0nX8a8gqWgNpks5rslyGgaJpZM4My1mv> .

[KarelVesely84]

Hi apparently this is not true (It's from the GCC docs):

There are a number of command-line options you can use to add additional directories to the search path. The most commonly-used option is -Idir, which causes dir to be searched after the current directory (for the quote form of the directive) and ahead of the standard system directories. You can specify multiple -I options on the command line, in which case the directories are searched in left-to-right order.

The order for #include "fst/fstlib.h" is following:

1. local directory [our kaldi src/subdir]
2. -I dirs [our local openfst]
3. system includes [the system installation of openfst]

[danpovey]

hm, OK. Merging.

[KarelVesely84]

Thanks Dan!