- Notifications
You must be signed in to change notification settings - Fork 5.4k
[WIP] sMBR on LFR with shifted feats #1477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…-regular Make the branch up-to-date
…-regular Merge Kaldi 5.1
| cool. |
| OK. So, I will now do these experiments on a chain-TDNN baseline. |
| yes I want to merge it- I'll wait for those changes. …On Mon, Mar 6, 2017 at 1:41 PM, Hossein Hadian ***@***.***> wrote: OK. Do you want to merge it? If yes, first I need to change the code to expand ivector scp using a new script copy_ivector_dir.sh as we discussed (currently I am doing it with a for loop in the main script). So, I will now do these experiments on a chain-TDNN baseline. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#1477 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADJVu9X7UsMSOaX9o4ki4278kNz-VK-3ks5rjFNLgaJpZM4MUgHV> . |
| if [[ "$shift_feats" = true && $frame_subsampling_factor -ne 1 ]]; then | ||
| if [ $stage -le 0 ]; then | ||
| utils/data/shift_and_combine_feats.sh --write-utt2orig ${train_data_dir}/utt2orig \ | ||
| $frame_subsampling_factor $train_data_dir ${train_data_dir}_fs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I write utt2orig file in ${train_data_dir}/utt2orig and then delete it. I guess this is not very good practice because the source directory might be read-only. Do you want me to write it to the current directory and delete it?
| yes please. [you can use some dir that you know you are outputting to, as a temp dir.] …On Mon, Mar 6, 2017 at 11:03 PM, Hossein Hadian ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In egs/swbd/s5c/local/nnet3/tuning/run_tdnn_lfr1c_disc.sh <#1477 (comment)>: > +if [ ! -f ${srcdir}/final.mdl ]; then + echo "$0: expected ${srcdir}/final.mdl to exist" + exit 1; +fi + + +frame_subsampling_factor=1 +if [ -f $srcdir/frame_subsampling_factor ]; then + frame_subsampling_factor=$(cat $srcdir/frame_subsampling_factor) +fi + +affix= # Will be set if doing input frame shift +if [[ "$shift_feats" = true && $frame_subsampling_factor -ne 1 ]]; then + if [ $stage -le 0 ]; then + utils/data/shift_and_combine_feats.sh --write-utt2orig ${train_data_dir}/utt2orig \ + $frame_subsampling_factor $train_data_dir ${train_data_dir}_fs I write utt2orig file in ${train_data_dir}/utt2orig and then delete it. I guess this is not very good practice because the source directory might be read-only. Do you want me to write it to the current directory and delete it? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#1477 (review)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADJVu3S-SOt1SlCuB31OvDNbOwsCB4vjks5rjOUYgaJpZM4MUgHV> . |
| This is ready [unless there is anything I need to fix about copy_ivector_dir.sh] |
| thanks- merging. |
* 'master' of https://github.com/kaldi-asr/kaldi: [build] Bump OpenFst version to v1.6.2 (kaldi-asr#1492) [src] nnet1: fixing issue in multi-task training (kaldi-asr#1491) [egs] Fixes to URLs in vystadial example script. [egs] Minor cosmetic changes in voxforge example script (kaldi-asr#1483) [scripts,egs] sMBR on LFR xent system with shifted feats (kaldi-asr#1477) [src] bug-fix in gst plugin code (issue on g++ 5.4.0) (kaldi-asr#1479)
This is the result (the experiment with shifted feats has
_fs_smbras the end):Overall there is 0.2-0.3 improvement due to shifted features.