upgrade the sox calls to use more compatible options #1453
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Contributor
| Could you just confirm that the dynamic range of the sox output is the same as before ? Only concern I have is that the nnet3 models which do not have mean variance normalization might be affected if there is any change in the dynamic range of the waveforms. |
Contributor
| otherwise LGTM. |
Contributor
| i think it should be safe, I've found online refs to an error message saying: Error: /usr/bin/sox WARN sox: Option `-s' is deprecated, use `-e signed- integer' instead …On Fri, Feb 24, 2017 at 12:18 PM, Vijayaditya Peddinti < ***@***.***> wrote: otherwise LGTM. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#1453 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADJVu-T05FucQgzJcH7WZZsRAUVQ1Eeyks5rfxDWgaJpZM4MLU2C> . |
Contributor
| OK merging. |
david-ryan-snyder pushed a commit to david-ryan-snyder/kaldi that referenced this pull request Apr 12, 2017
Skaiste pushed a commit to Skaiste/idlak that referenced this pull request Sep 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
@vijayaditya @pswietojanski
I did a run on the s5b recipe until mono-training and it seemed to work fine as far as I can tell.
do you wanna do more careful checks?