Skip to content

Conversation

@yeikel
Copy link
Collaborator

@yeikel yeikel commented Dec 13, 2024

Description

Before this change, we were using both Confluent Artifacts (via confluent.version) as well as the OSS artifacts (via kafka-clients.version and kafka.version ).

With this change, we are upgrading and aligning the versions to use the Confluent Kafka Distribution. This helps us not only to reduce the attack surface but also to simplify the dependency upgrades

As a side effect of this upgrade, we are also extending the retry logic to retry when there is a re-balance in progress as that was previously failing silently as described in https://issues.apache.org/jira/browse/KAFKA-14455

Closes #693
Closes #692

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

A picture of a cute animal (not mandatory but encouraged)

p03t268b

@kapybro kapybro bot added status/triage Issues pending maintainers triage status/triage/manual Manual triage in progress status/triage/completed Automatic triage completed and removed status/triage Issues pending maintainers triage labels Dec 13, 2024
@yeikel yeikel changed the title align kafka versions BE: align kafka versions Dec 13, 2024
@yeikel yeikel force-pushed the align-kafka branch 3 times, most recently from d14e788 to ffa161f Compare December 13, 2024 06:22
@yeikel yeikel changed the title BE: align kafka versions BE: align kafka version Dec 13, 2024
@yeikel yeikel changed the title BE: align kafka version BE: upgrade to Kafka 7.8.0 Dec 13, 2024
@yeikel yeikel force-pushed the align-kafka branch 2 times, most recently from 9bbf455 to 3726917 Compare December 13, 2024 06:44
@yeikel yeikel force-pushed the align-kafka branch 11 times, most recently from 83d88e6 to 5c1a7e5 Compare December 18, 2024 00:32
@yeikel yeikel marked this pull request as ready for review December 18, 2024 00:42
@yeikel yeikel requested review from a team as code owners December 18, 2024 00:42
@Haarolean Haarolean added scope/backend Related to backend changes type/dependencies A pull request/issue dedicated to updating the dependency(-ies) and removed status/triage/manual Manual triage in progress labels Dec 18, 2024
@yeikel yeikel requested a review from DimaVilda December 19, 2024 03:11
@Haarolean
Copy link
Member

@yeikel this e2e test seem to be failing, could you take a look?
TopicsTest.retentionBytesAccordingToMaxSizeOnDiskCheck:413 » NoSuchElement No value present

@yeikel yeikel requested a review from a team as a code owner December 23, 2024 01:33
@yeikel yeikel force-pushed the align-kafka branch 2 times, most recently from e9b8c54 to 69a00d0 Compare December 23, 2024 03:48
@yeikel
Copy link
Collaborator Author

yeikel commented Dec 23, 2024

@yeikel this e2e test seem to be failing, could you take a look? TopicsTest.retentionBytesAccordingToMaxSizeOnDiskCheck:413 » NoSuchElement No value present

@Haarolean I updated the test.

The reason it was failing is because the page was returning 2 pages and the test assumed that all the properties are visible within the first page

@Haarolean Haarolean changed the title BE: upgrade to Kafka 7.8.0 BE: Chore: Upgrade kafka to confluent 7.8.0 Dec 23, 2024
@Haarolean Haarolean added this to the 1.1 milestone Dec 23, 2024
@Haarolean Haarolean merged commit a9bc82c into kafbat:main Dec 23, 2024
12 of 14 checks passed
@Haarolean
Copy link
Member

@yeikel thank you very much for this PR!

@yeikel yeikel deleted the align-kafka branch December 23, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope/backend Related to backend changes status/triage/completed Automatic triage completed type/dependencies A pull request/issue dedicated to updating the dependency(-ies)

3 participants