Skip to content

Conversation

@wernerdv
Copy link
Contributor

@wernerdv wernerdv commented Dec 3, 2024

  • Breaking change? (if so, please describe the impact and migration path for existing application instances)

What changes did you make? (Give an overview)
Fixed #256

Is there anything you'd like reviewers to focus on?

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • No need to
  • Manually (please, describe, if necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

A picture of a cute animal (not mandatory but encouraged)

@wernerdv wernerdv requested a review from a team as a code owner December 3, 2024 08:34
@kapybro kapybro bot added status/triage Issues pending maintainers triage status/triage/manual Manual triage in progress status/triage/completed Automatic triage completed and removed status/triage Issues pending maintainers triage labels Dec 3, 2024
fix build
@wernerdv wernerdv requested a review from a team as a code owner December 3, 2024 09:02
fix build
@Haarolean Haarolean added scope/backend Related to backend changes type/security Pull requests that address a security vulnerability and removed status/triage/manual Manual triage in progress labels Dec 3, 2024
@Haarolean Haarolean merged commit ec324dc into kafbat:main Dec 3, 2024
13 of 14 checks passed
@Haarolean
Copy link
Member

@wernerdv thanks for another contribution!

@wernerdv wernerdv deleted the issues/256 branch December 3, 2024 10:58
K-Diger pushed a commit to K-Diger/kafbat-kafka-ui that referenced this pull request Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope/backend Related to backend changes status/triage/completed Automatic triage completed type/security Pull requests that address a security vulnerability

2 participants