Skip to content

FE: RBAC: Fix connector permissions checks #415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 26, 2024
Merged

FE: RBAC: Fix connector permissions checks #415

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ec7c114
FE: RBAC: Fix connector permissions checks
Haarolean May 25, 2024
be9f58c
Merge branch 'main' into issues/414
Haarolean May 25, 2024
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions frontend/src/components/Connect/Details/Actions/Actions.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ const Actions: React.FC = () => {
permission={{
resource: ResourceType.CONNECT,
action: Action.EDIT,
value: routerProps.connectorName,
value: routerProps.connectName,
}}
>
Pause
Expand All @@ -91,7 +91,7 @@ const Actions: React.FC = () => {
permission={{
resource: ResourceType.CONNECT,
action: Action.EDIT,
value: routerProps.connectorName,
value: routerProps.connectName,
}}
>
Resume
Expand All @@ -103,7 +103,7 @@ const Actions: React.FC = () => {
permission={{
resource: ResourceType.CONNECT,
action: Action.RESTART,
value: routerProps.connectorName,
value: routerProps.connectName,
}}
>
Restart Connector
Expand All @@ -114,7 +114,7 @@ const Actions: React.FC = () => {
permission={{
resource: ResourceType.CONNECT,
action: Action.RESTART,
value: routerProps.connectorName,
value: routerProps.connectName,
}}
>
Restart All Tasks
Expand All @@ -125,7 +125,7 @@ const Actions: React.FC = () => {
permission={{
resource: ResourceType.CONNECT,
action: Action.RESTART,
value: routerProps.connectorName,
value: routerProps.connectName,
}}
>
Restart Failed Tasks
Expand All @@ -139,7 +139,7 @@ const Actions: React.FC = () => {
permission={{
resource: ResourceType.CONNECT,
action: Action.DELETE,
value: routerProps.connectorName,
value: routerProps.connectName,
}}
>
Delete
Expand Down
2 changes: 1 addition & 1 deletion frontend/src/components/Connect/Details/Tasks/ActionsCellTasks.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ const ActionsCellTasks: React.FC<CellContext<Task, unknown>> = ({ row }) => {
permission={{
resource: ResourceType.CONNECT,
action: Action.RESTART,
value: routerProps.connectorName,
value: routerProps.connectName,
}}
>
<span>Restart task</span>
Expand Down
8 changes: 4 additions & 4 deletions frontend/src/components/Connect/List/ActionsCell.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ const ActionsCell: React.FC<CellContext<FullConnectorInfo, unknown>> = ({
permission={{
resource: ResourceType.CONNECT,
action: Action.EDIT,
value: name,
value: connect,
}}
>
Resume
Expand All @@ -79,7 +79,7 @@ const ActionsCell: React.FC<CellContext<FullConnectorInfo, unknown>> = ({
permission={{
resource: ResourceType.CONNECT,
action: Action.RESTART,
value: name,
value: connect,
}}
>
Restart Connector
Expand All @@ -90,7 +90,7 @@ const ActionsCell: React.FC<CellContext<FullConnectorInfo, unknown>> = ({
permission={{
resource: ResourceType.CONNECT,
action: Action.RESTART,
value: name,
value: connect,
}}
>
Restart All Tasks
Expand All @@ -101,7 +101,7 @@ const ActionsCell: React.FC<CellContext<FullConnectorInfo, unknown>> = ({
permission={{
resource: ResourceType.CONNECT,
action: Action.RESTART,
value: name,
value: connect,
}}
>
Restart Failed Tasks
Expand Down