-
- Notifications
You must be signed in to change notification settings - Fork 192
FE: Add forms for an ACL creating #188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Haarolean requested changes Mar 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Can we use the same type of button as in topics? Current one has a weird shape of a plus sign
- The form is quite unreadable with the dark theme
- Can we please make the table sortable? Via our default sorting logic, for starters.
- Checked checkmark has the blue background, doesn't math our new grey shade theme
- "prefixed" input doesn't have the "prefix..." tooltip in some tabs
TODO Backend: We'd need to fix some 500s on the backend which we get in case of some fields don't pass the validation
Mgrdich reviewed Mar 5, 2024
frontend/src/components/common/Select/ControlledSelect.styled.ts Outdated Show resolved Hide resolved
Mgrdich reviewed Mar 16, 2024
Closed
Mgrdich approved these changes Mar 17, 2024
Haarolean approved these changes Mar 18, 2024
|
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/acl scope/frontend Related to frontend changes status/triage/completed Automatic triage completed type/feature A brand new feature
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.




What changes did you make? (Give an overview)
Is there anything you'd like reviewers to focus on?
How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)
Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)
Check out Contributing and Code of Conduct
A picture of a cute animal (not mandatory but encouraged)