Skip to content

Conversation

@ankitk-me
Copy link
Contributor

  • Breaking change? (if so, please describe the impact and migration path for existing application instances)

What changes did you make? (Give an overview)
Added support for the optional awsRoleArn configuration when using IAM authentication.

Is there anything you'd like reviewers to focus on?
In addition to awsRoleArn, I have also added awsRoleSessionName & awsStsRegion as defined here in MSK IAM Auth Library.

sasl.jaas.config=software.amazon.msk.auth.iam.IAMLoginModule required awsRoleArn="arn:aws:iam::123456789012:role/msk_client_role" awsRoleSessionName="producer" awsStsRegion="us-west-2"; 

Docs PR: kafbat/ui-docs#61

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • No need to
  • Manually (please, describe, if necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

A picture of a cute animal (not mandatory but encouraged)

@ankitk-me ankitk-me requested a review from a team as a code owner June 21, 2025 05:30
@kapybro kapybro bot added status/triage Issues pending maintainers triage area/auth App authentication related issues status/triage/manual Manual triage in progress status/triage/completed Automatic triage completed and removed status/triage Issues pending maintainers triage labels Jun 21, 2025
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi ankitk-me! 👋

Welcome, and thank you for opening your first PR in the repo!

Please wait for triaging by our maintainers.

Please take a look at our contributing guide.

@Haarolean
Copy link
Member

Hi, thanks for the PR. Does everything work with these changes?

@Haarolean Haarolean added type/enhancement En enhancement/improvement to an already existing feature scope/frontend Related to frontend changes area/wizard UI configuration wizard issues and removed area/auth App authentication related issues status/triage/manual Manual triage in progress labels Jun 21, 2025
@Haarolean Haarolean added this to the 1.3 milestone Jun 21, 2025
@ankitk-me
Copy link
Contributor Author

ankitk-me commented Jun 21, 2025

@Haarolean yes works as expected. I was able to create a local docker image and validate these changes.

@github-project-automation github-project-automation bot moved this from Todo to PR Approved in Release 1.3 Jun 22, 2025
@Haarolean Haarolean merged commit 9c6b622 into kafbat:main Jun 22, 2025
32 of 33 checks passed
@github-project-automation github-project-automation bot moved this from PR Approved to Done in Release 1.3 Jun 22, 2025
@Haarolean
Copy link
Member

@ankitk-me thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/wizard UI configuration wizard issues scope/frontend Related to frontend changes status/triage/completed Automatic triage completed type/enhancement En enhancement/improvement to an already existing feature

3 participants