evalCode(type=module) throws instead of returning rejected promise #161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fixes #160
New versions of quickjs library return
Promise<void>when evaluating a module.Our wrapper code unwrapped this implicit promise if it's resolved and return the module exports, and replace a pending promise with pending
Promise<ModuleExports>.However, our code passed through the rejected promise value as a success result back to the caller, who probably isn't expecting a promise.
With this PR, we consider the sync rejected module evaluation promise as an error, restoring the behavior of errors thrown during evaluation.
Also:
context.dump(val)now inspects promises