feat(custom-esbuild): expose current builder options and target to plugins #1878
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
mattlewis92 force-pushed the expose-target-and-options-to-plugins branch from b5080b3 to 33e1f46 Compare 
mattlewis92 force-pushed the expose-target-and-options-to-plugins branch from 33e1f46 to fc44e3a Compare 
| will this PR make be merged, it will be nice to have the target options? |
| ping? |
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The current build target and options are not exposed to plugins, so it's hard to share plugins between all projects in a repo or access current build options.
Issue Number: N/A
What is the new behavior?
The plugins file can expose a factory function that accepts the builder options and target and produces a set of plugins based on the current target and options, which matches the webpack builder behaviour.
Does this PR introduce a breaking change?
Other information
Our use case is we want to have a single set of plugins shared between all our applications that can:
defineoption to set the current project name in the codebasestylePreprocessorOptionsoption value so we can add an additional esbuild sass plugin to support react css modules written in scss.