Skip to content

Add comments and fix bug #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 27, 2020
Merged

Add comments and fix bug #96

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
36127c0
Add language icons
jahn96 Aug 26, 2020
be87571
Make change on searching and fix invalid input border
jahn96 Aug 26, 2020
29acd9b
Add comments and delete console log
jahn96 Aug 27, 2020
3e0e596
Fix bug with icon not inlining with a name with one character
jahn96 Aug 27, 2020
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
60 changes: 45 additions & 15 deletions src/CodeSnippetDisplay.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,7 @@ import {
rustIcon,
qsharpIcon
} from './CodeSnippetLanguages';

/**
* The CSS class added to code snippet widget.
*/
Expand Down Expand Up @@ -268,7 +269,7 @@ export class CodeSnippetDisplay extends React.Component<
});
};

// Insert 6 dots on hover
// Create 6 dots drag/drop image on hover
private dragHoverStyle = (id: string): void => {
const _id: number = parseInt(id, 10);

Expand Down Expand Up @@ -303,12 +304,8 @@ export class CodeSnippetDisplay extends React.Component<
.toLowerCase()
.indexOf(searchValue.toLowerCase());

// Pythonlanguage
// if (startIndex > language.length - 1) {
// }
const endIndex: number = startIndex + searchValue.length;
console.log(endIndex);
console.log(language.length);

if (endIndex <= language.length) {
return <span>{name}</span>;
} else {
Expand Down Expand Up @@ -449,11 +446,8 @@ export class CodeSnippetDisplay extends React.Component<
}

private _evtMouseLeave(): void {
//get rid of preview by clicking anything
const preview = document.querySelector('.jp-codeSnippet-preview');
if (preview) {
// if target is not the code snippet name area, then add inactive
// if target area is the code snippet name area, previewSnippet widget will handle preview.
if (!preview.classList.contains('inactive')) {
preview.classList.add('inactive');
}
Expand Down Expand Up @@ -506,6 +500,7 @@ export class CodeSnippetDisplay extends React.Component<
return (
<pythonIcon.react
tag="span"
height="16px"
width="16px"
right="7px"
top="5px"
Expand All @@ -517,6 +512,7 @@ export class CodeSnippetDisplay extends React.Component<
return (
<javaIcon.react
tag="span"
height="16px"
width="16px"
right="7px"
top="5px"
Expand All @@ -528,6 +524,7 @@ export class CodeSnippetDisplay extends React.Component<
return (
<rKernelIcon.react
tag="span"
height="16px"
width="16px"
right="7px"
top="5px"
Expand All @@ -539,6 +536,7 @@ export class CodeSnippetDisplay extends React.Component<
return (
<juliaIcon.react
tag="span"
height="16px"
width="16px"
right="7px"
top="5px"
Expand All @@ -550,6 +548,7 @@ export class CodeSnippetDisplay extends React.Component<
return (
<matlabIcon.react
tag="span"
height="16px"
width="16px"
right="7px"
top="5px"
Expand All @@ -561,6 +560,7 @@ export class CodeSnippetDisplay extends React.Component<
return (
<schemeIcon.react
tag="span"
height="16px"
width="16px"
right="7px"
top="5px"
Expand All @@ -572,6 +572,7 @@ export class CodeSnippetDisplay extends React.Component<
return (
<processingIcon.react
tag="span"
height="16px"
width="16px"
right="7px"
top="5px"
Expand All @@ -583,6 +584,7 @@ export class CodeSnippetDisplay extends React.Component<
return (
<scalaIcon.react
tag="span"
height="16px"
width="16px"
right="7px"
top="5px"
Expand All @@ -594,6 +596,7 @@ export class CodeSnippetDisplay extends React.Component<
return (
<groovyIcon.react
tag="span"
height="16px"
width="16px"
right="7px"
top="5px"
Expand All @@ -605,6 +608,7 @@ export class CodeSnippetDisplay extends React.Component<
return (
<fortranIcon.react
tag="span"
height="16px"
width="16px"
right="7px"
top="5px"
Expand All @@ -616,6 +620,7 @@ export class CodeSnippetDisplay extends React.Component<
return (
<haskellIcon.react
tag="span"
height="16px"
width="16px"
right="7px"
top="5px"
Expand All @@ -627,6 +632,7 @@ export class CodeSnippetDisplay extends React.Component<
return (
<rubyIcon.react
tag="span"
height="16px"
width="16px"
right="7px"
top="5px"
Expand All @@ -638,6 +644,7 @@ export class CodeSnippetDisplay extends React.Component<
return (
<typescriptIcon.react
tag="span"
height="16px"
width="16px"
right="7px"
top="5px"
Expand All @@ -649,6 +656,7 @@ export class CodeSnippetDisplay extends React.Component<
return (
<javascriptIcon.react
tag="span"
height="16px"
width="16px"
right="7px"
top="5px"
Expand All @@ -660,6 +668,7 @@ export class CodeSnippetDisplay extends React.Component<
return (
<coffeescriptIcon.react
tag="span"
height="16px"
width="16px"
right="7px"
top="5px"
Expand All @@ -671,6 +680,7 @@ export class CodeSnippetDisplay extends React.Component<
return (
<livescriptIcon.react
tag="span"
height="16px"
width="16px"
right="7px"
top="5px"
Expand All @@ -682,6 +692,7 @@ export class CodeSnippetDisplay extends React.Component<
return (
<csharpIcon.react
tag="span"
height="16px"
width="16px"
right="7px"
top="5px"
Expand All @@ -693,6 +704,7 @@ export class CodeSnippetDisplay extends React.Component<
return (
<fsharpIcon.react
tag="span"
height="16px"
width="16px"
right="7px"
top="5px"
Expand All @@ -704,6 +716,7 @@ export class CodeSnippetDisplay extends React.Component<
return (
<goIcon.react
tag="span"
height="16px"
width="16px"
right="7px"
top="5px"
Expand All @@ -715,6 +728,7 @@ export class CodeSnippetDisplay extends React.Component<
return (
<erlangIcon.react
tag="span"
height="16px"
width="16px"
right="7px"
top="5px"
Expand All @@ -726,6 +740,7 @@ export class CodeSnippetDisplay extends React.Component<
return (
<ocamlIcon.react
tag="span"
height="16px"
width="16px"
right="7px"
top="5px"
Expand All @@ -737,6 +752,7 @@ export class CodeSnippetDisplay extends React.Component<
return (
<forthIcon.react
tag="span"
height="16px"
width="16px"
right="7px"
top="5px"
Expand All @@ -748,6 +764,7 @@ export class CodeSnippetDisplay extends React.Component<
return (
<perlIcon.react
tag="span"
height="16px"
width="16px"
right="7px"
top="5px"
Expand All @@ -759,6 +776,7 @@ export class CodeSnippetDisplay extends React.Component<
return (
<phpIcon.react
tag="span"
height="16px"
width="16px"
right="7px"
top="5px"
Expand All @@ -770,6 +788,7 @@ export class CodeSnippetDisplay extends React.Component<
return (
<clojureIcon.react
tag="span"
height="16px"
width="16px"
right="7px"
top="5px"
Expand All @@ -781,6 +800,7 @@ export class CodeSnippetDisplay extends React.Component<
return (
<luaIcon.react
tag="span"
height="16px"
width="16px"
right="7px"
top="5px"
Expand All @@ -792,6 +812,7 @@ export class CodeSnippetDisplay extends React.Component<
return (
<purescriptIcon.react
tag="span"
height="16px"
width="16px"
right="7px"
top="5px"
Expand All @@ -803,6 +824,7 @@ export class CodeSnippetDisplay extends React.Component<
return (
<cppIcon.react
tag="span"
height="16px"
width="16px"
right="7px"
top="5px"
Expand All @@ -814,6 +836,7 @@ export class CodeSnippetDisplay extends React.Component<
return (
<prologIcon.react
tag="span"
height="16px"
width="16px"
right="7px"
top="5px"
Expand All @@ -825,6 +848,7 @@ export class CodeSnippetDisplay extends React.Component<
return (
<lispIcon.react
tag="span"
height="16px"
width="16px"
right="7px"
top="5px"
Expand All @@ -836,6 +860,7 @@ export class CodeSnippetDisplay extends React.Component<
return (
<cIcon.react
tag="span"
height="16px"
width="16px"
right="7px"
top="5px"
Expand All @@ -847,6 +872,7 @@ export class CodeSnippetDisplay extends React.Component<
return (
<kotlinIcon.react
tag="span"
height="16px"
width="16px"
right="7px"
top="5px"
Expand All @@ -858,6 +884,7 @@ export class CodeSnippetDisplay extends React.Component<
return (
<nodejsIcon.react
tag="span"
height="16px"
width="16px"
right="7px"
top="5px"
Expand All @@ -869,6 +896,7 @@ export class CodeSnippetDisplay extends React.Component<
return (
<coconutIcon.react
tag="span"
height="16px"
width="16px"
right="7px"
top="5px"
Expand All @@ -880,6 +908,7 @@ export class CodeSnippetDisplay extends React.Component<
return (
<babelIcon.react
tag="span"
height="16px"
width="16px"
right="7px"
top="5px"
Expand All @@ -891,6 +920,7 @@ export class CodeSnippetDisplay extends React.Component<
return (
<sbtIcon.react
tag="span"
height="16px"
width="16px"
right="7px"
top="5px"
Expand All @@ -902,6 +932,7 @@ export class CodeSnippetDisplay extends React.Component<
return (
<rustIcon.react
tag="span"
height="16px"
width="16px"
right="7px"
top="5px"
Expand All @@ -913,6 +944,7 @@ export class CodeSnippetDisplay extends React.Component<
return (
<qsharpIcon.react
tag="span"
height="16px"
width="16px"
right="7px"
top="5px"
Expand All @@ -924,6 +956,7 @@ export class CodeSnippetDisplay extends React.Component<
return (
<fileIcon.react
tag="span"
height="16px"
width="16px"
right="7px"
top="5px"
Expand All @@ -933,6 +966,7 @@ export class CodeSnippetDisplay extends React.Component<
}
}
}

// Render display of code snippet list
private renderCodeSnippet = (
codeSnippet: ICodeSnippet,
Expand Down Expand Up @@ -1038,8 +1072,6 @@ export class CodeSnippetDisplay extends React.Component<
props: ICodeSnippetDisplayProps,
state: ICodeSnippetDisplayState
): ICodeSnippetDisplayState {
console.log(props.codeSnippets);
console.log(state.codeSnippets);
if (
props.codeSnippets !== state.codeSnippets &&
state.searchValue === '' &&
Expand Down Expand Up @@ -1081,7 +1113,6 @@ export class CodeSnippetDisplay extends React.Component<
filterTags: filterTags
},

// { codeSnippets: newSnippets, searchValue: this.state.searchValue },
() => {
console.log('CodeSnippets are succesfully filtered.');
}
Expand Down Expand Up @@ -1170,7 +1201,6 @@ export class CodeSnippetDisplay extends React.Component<
editSnip.className = CODE_SNIPPET_MORE_OTPIONS_EDIT;
editSnip.textContent = 'Edit snippet';
editSnip.onclick = (): void => {
console.log(codeSnippet);
const allTags = this.getActiveTags();
this.props.openCodeSnippetEditor({
name: codeSnippet.name,
Expand Down Expand Up @@ -1238,8 +1268,8 @@ export class CodeSnippetDisplay extends React.Component<
}

class OptionsHandler extends Widget {
constructor(object: CodeSnippetDisplay, codeSnippet: ICodeSnippet) {
super({ node: object.createOptionsNode(codeSnippet) });
constructor(display: CodeSnippetDisplay, codeSnippet: ICodeSnippet) {
super({ node: display.createOptionsNode(codeSnippet) });
}
}

Expand Down
Loading