Skip to content

Conversation

@vidartf
Copy link
Member

@vidartf vidartf commented Feb 17, 2023

Without this compatibility shim (https://ipywidgets.readthedocs.io/en/stable/migration_guides.html#phosphor-lumino), we no longer handle contextmenu events correctly (with ipywidgets 8).

Fixes #392.

Without this compatibility shim (https://ipywidgets.readthedocs.io/en/stable/migration_guides.html#phosphor-lumino), we no longer handle `contextmenu` events correctly.
@vidartf vidartf added the bug label Feb 17, 2023
@codecov-commenter
Copy link

codecov-commenter commented Feb 17, 2023

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.54%. Comparing base (7dacddf) to head (99f9a9a).
⚠️ Report is 8 commits behind head on master.

Additional details and impacted files
@@ Coverage Diff @@ ## master #397 +/- ## ======================================= Coverage 70.54% 70.54% ======================================= Files 23 23 Lines 893 893 ======================================= Hits 630 630 Misses 263 263 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
@vidartf vidartf merged commit 6102f0c into jupyter-widgets:master Feb 19, 2023
@vidartf vidartf deleted the fix-contextmenu branch February 19, 2023 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2 participants