Skip to content

Conversation

@akaszynski
Copy link
Contributor

@akaszynski akaszynski commented Apr 21, 2022

Upgrade to threejs r112.

Remaining wrappers

  • PMREMGenerator (API changed from method to class, delaying wrapper)
  • LightProbe
  • LightProbeHelper
  • PositionalAudioHelper
  • SphericalHarmonics3
  • InstancedMesh
  • AmbientLightProbe
  • HemisphereLightProbe
  • PointLightShadow
  • WebGLMultisampleRenderTarget
  • WebGLMultiviewRenderTarget
  • DataTexture2DArray
  • WebGLMultiview

Changes

  • .drawMode has been removed

Bonus

@akaszynski akaszynski mentioned this pull request Apr 21, 2022
12 tasks
@akaszynski
Copy link
Contributor Author

@maartenbreddels, I'm going to try to support r112 first and then go from there.

@jasongrout, I'd like to help maintain this repository. Please message me at akascap@gmail.com if you think that's possible. I think this is an excellent repository and it's been 6 months since the last commit and around a year since a release. I'd really like to help.

@jasongrout
Copy link
Member

jasongrout commented Apr 21, 2022

Awesome, thanks for volunteering! @vidartf is the current main maintainer. @vidartf?

@codecov-commenter
Copy link

codecov-commenter commented Apr 21, 2022

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.86%. Comparing base (a78cb57) to head (9b34f5f).
Report is 56 commits behind head on master.

Additional details and impacted files
@@ Coverage Diff @@ ## master #376 +/- ## ======================================= Coverage 70.86% 70.86% ======================================= Files 23 23 Lines 834 834 ======================================= Hits 591 591 Misses 243 243 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
@akaszynski
Copy link
Contributor Author

@jasongrout, I've not heard back from @vidartf and he's not been active on github as of late.

Is there any chance I can get hold of one of the other maintainers?

@jasongrout
Copy link
Member

@vidartf was in the ipywidgets dev meeting this morning, so pinging him again.

@vidartf
Copy link
Member

vidartf commented Apr 29, 2022

Hi @akaszynski , I'm around, and I'm more than happy to have others help out here! Thanks for volunteering! I am going to do an effort on this repo in the few coming days to add support for ipywidgets 8, but do not really plan to be working on features beyond that, so happy to leave that to you!

If you need me on a quicker turn-around than me checking my GH pings, you should be able to find my email address on the commits. Let's get a few PR's/commits through, and then get you set up with commit/publish rights after. Did you want me to review this PR in its current state?

@akaszynski akaszynski closed this Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants