Feature: JupyterLab 3.0 Support Cleanup #350
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Co-authored-by: Jason Grout <jasongrout@users.noreply.github.com>
Also use __file__ to determine path
Also, convert pathlib.Path instances to str for consistency
vidartf reviewed Feb 15, 2021
vidartf reviewed Feb 15, 2021
Co-authored-by: Vidar Tonaas Fauske <vidartf@gmail.com>
As we now require setuptools>=40.8.0, we are guaranteed to include the LICENSE, README.md, and pyproject.toml files: https://packaging.python.org/guides/using-manifest-in/#how-files-are-included-in-an-sdist
Member
| Merged, will iterate as needed |
Contributor Author
| Thanks a bunch @vidartf et al., I appreciate the help! |
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This PR re-runs some of my changes (from maartenbreddels#2) on top of @maartenbreddels original PR (#342) to ensure a cleaner Git history.
I hope that @maartenbreddels is happy for this PR to replace #342
The main changes are updating the version numbers, and moving the build directory to the
pythreejs/labextensionto shorten the paths and follow the cookie-cutter design.Apologies for all the noise lately, in future I'll keep the PRs smaller in scope.
The following comment might still apply:
#342 (comment)