Skip to content

Support lab 2.0 #315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vidartf merged 3 commits into from
Mar 17, 2020
Merged

Support lab 2.0 #315

vidartf merged 3 commits into from
Mar 17, 2020

Conversation

@vidartf
Copy link
Member

@vidartf vidartf commented Mar 16, 2020

Upgrades widgets dependency to support lab 2.0 (while retaining support for older versions). Also upgrades some dev dependencies.
@vidartf vidartf merged commit b3a2ac5 into jupyter-widgets:master Mar 17, 2020
@vidartf vidartf deleted the lab-2 branch March 17, 2020 15:10
@SylvainCorlay
Copy link
Member

SylvainCorlay commented Mar 17, 2020

You may need to change jupyterlab-plugin.ts by adding as any to base.IJupyterWidgetRegistry.

This has caused us issues in other extensions.
@vidartf
Copy link
Member Author

vidartf commented Mar 18, 2020

@SylvainCorlay I thought this project used vanilla JS? :)
@SylvainCorlay
Copy link
Member

SylvainCorlay commented Mar 18, 2020

lol indeed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@vidartf @SylvainCorlay