Autogen: Fixes and improvements #108
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Give it better visibility and add a docstring.
Further highlight that most three widgets are models only.
This allows access to vertices etc. generated by geometry creator classes.
The rendering calls were streamlined to avoid unneeded calls + fix cases where things were not called but should have.
Main point is to at least ensure animations are stopped and that we do as little work as possible (context is normally lost for resource reasons).
Most browsers have 8 or 16, so floor it to the lowest we think we are guaranteed to have.
vidartf changed the title Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Iteration on the autogen branch.
Highlights:
PlainGeometry.from_geometryfactory to copy another geometry.See individual commits for details.