Skip to content

GCC 4.8 compatibility #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 25, 2018
Merged

GCC 4.8 compatibility #132

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b5d3b3e
Use GCC 4.8 to test compatibility
gjasny Jul 24, 2018
63a5c61
Make push gateway GCC 4.8 compatible
gjasny Jul 24, 2018
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,7 @@ env:
install:
- sudo apt-get update
- sudo apt-get install -y software-properties-common cmake curl python-pip git lcov libcurl4-openssl-dev
- sudo add-apt-repository -y ppa:ubuntu-toolchain-r/test
- sudo apt-get update
- sudo apt-get install -y gcc-5 g++-5
- sudo update-alternatives --install /usr/bin/gcc gcc /usr/bin/gcc-5 1 --slave /usr/bin/g++ g++ /usr/bin/g++-5
- sudo apt-get install -y gcc-4.8 g++-4.8
- sudo add-apt-repository -y ppa:webupd8team/java
- echo "oracle-java8-installer shared/accepted-oracle-license-v1-1 select true" | sudo debconf-set-selections
- sudo apt-get install -o Dpkg::Options::="--force-confnew" -y oracle-java8-installer
Expand Down
4 changes: 2 additions & 2 deletions push/src/gateway.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ int Gateway::push(PushMode mode) {
metrics.push_back(metric);
}

auto uri = std::stringstream{};
std::stringstream uri;
uri << jobUri_ << labels_ << wcollectable.second;

auto body = serializer.Serialize(metrics);
Expand Down Expand Up @@ -101,7 +101,7 @@ std::future<int> Gateway::async_push(PushMode mode) {
metrics.push_back(metric);
}

auto uri = std::stringstream{};
std::stringstream uri;
uri << jobUri_ << labels_ << wcollectable.second;

auto body = serializer.Serialize(metrics);
Expand Down