Skip to content

deprecate disutils #574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 4, 2023
Merged

deprecate disutils #574

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions pymysqlreplication/binlogstream.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import struct
import logging
from distutils.version import LooseVersion
from packaging.version import Version

import pymysql
from pymysql.constants.COMMAND import COM_BINLOG_DUMP, COM_REGISTER_SLAVE
Expand Down Expand Up @@ -329,7 +329,7 @@ def _register_slave(self):

packet = self.report_slave.encoded(self.__server_id)

if pymysql.__version__ < LooseVersion("0.6"):
if Version(pymysql.__version__) < Version("0.6"):
self._stream_connection.wfile.write(packet)
self._stream_connection.wfile.flush()
self._stream_connection.read_packet()
Expand Down Expand Up @@ -501,7 +501,7 @@ def __connect_to_stream(self):
# encoded_data
prelude += gtid_set.encoded()

if pymysql.__version__ < LooseVersion("0.6"):
if Version(pymysql.__version__) < Version("0.6"):
self._stream_connection.wfile.write(prelude)
self._stream_connection.wfile.flush()
else:
Expand Down Expand Up @@ -587,7 +587,7 @@ def fetchone(self):
self.__connect_to_ctl()

try:
if pymysql.__version__ < LooseVersion("0.6"):
if Version(pymysql.__version__) < Version("0.6"):
pkt = self._stream_connection.read_packet()
else:
pkt = self._stream_connection._read_packet()
Expand Down