Parse status variables in query event #360
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Status variables contain useful information: 1. List of databases affected by the query 2. Runtime value of system variables (SQL_MODE, AUTOCOMMIT, CHARSET_SERVER, etc.) 3. timezone of the master For further information please refer to; [Syntax of system variables field in query event](https://dev.mysql.com/doc/internals/en/query-event.html#q-microseconds) [Definition of enumeration for system variable keys](https://github.com/mysql/mysql-server/blob/beb865a960b9a8a16cf999c323e46c5b0c67f21f/libbinlogevents/include/statement_events.h#L463-L532) [Semantics of system variable values](https://github.com/mysql/mysql-server/blob/beb865a960b9a8a16cf999c323e46c5b0c67f21f/libbinlogevents/include/statement_events.h#L156-L448)
| Sorry for the delay will look in details next week |
| Finnaly got time :D |
| Do you have notice a performance issue ? It seem to work fine |
| Nope, I've tested the new feature several times but not yet. I appreciate your kindness to review my PR despite your busy schedule. |
dongwook-chan referenced this pull request in the4thdoctor/pg_chameleon Mar 9, 2022
with encoding utf8mb4. TODO - file a bug report
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Status variables contain useful information:
ㅤ
ㅤ
Users of this library should benefit from new information.
However, if anyone raises performance issues regarding the logic,
this logic can revised to be provided selectively depending on a newly added option.
ㅤ
ㅤ
A status variable in query events is a sequence of status KEY-VALUE pairs.
pymysqlreplication.event.QueryEvent.__init__().pymysqlreplication.event.QueryEvent._read_status_vars_value_for_key().Added and passed tests.
ㅤ
ㅤ
For further information please refer to;