Skip to content

Conversation

@AriPerkkio
Copy link
Contributor

@AriPerkkio AriPerkkio commented Oct 31, 2021

Fixes "Invalid hook call" of https://github.com/yannickcr/eslint-plugin-react/runs/4057441339?check_suite_focus=true. See AriPerkkio/eslint-remote-tester#302. The previous smoke test was unable to log any output to stdout, but the test was still run successfully. Everything was linted properly, it was just the output which was missing.

@codecov-commenter
Copy link

codecov-commenter commented Oct 31, 2021

Codecov Report

Merging #3118 (4b824e0) into master (12f33f6) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@ ## master #3118 +/- ## ======================================= Coverage 97.52% 97.52% ======================================= Files 118 118 Lines 7914 7914 Branches 2833 2833 ======================================= Hits 7718 7718 Misses 196 196 

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12f33f6...4b824e0. Read the comment docs.

@AriPerkkio AriPerkkio force-pushed the deps/eslint-remote-tester-v2 branch from f98c591 to 4b824e0 Compare October 31, 2021 09:42
@AriPerkkio AriPerkkio changed the title [Dev Deps] update eslint-remote-tester, eslint-remote-tester-run-action [Dev Deps] update eslint-remote-tester Oct 31, 2021
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ljharb ljharb merged commit 4b824e0 into jsx-eslint:master Oct 31, 2021
@ljharb
Copy link
Member

ljharb commented Oct 31, 2021

It'd probably be nice if we could set things up so that when a PR is updating eslint-remote-tester specifically, it runs the remote tests as part of the PR :-)

@AriPerkkio AriPerkkio deleted the deps/eslint-remote-tester-v2 branch November 2, 2021 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants