[Dev Deps] Upgrade eslint-plugin-eslint-plugin to v4

[bmish]

https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/releases/tag/v4.0.0

• Replaces a few deprecated ESLint functions - eslint-plugin/no-deprecated-context-methods

eslint-plugin/require-meta-type would be a good rule to enable later.

[ljharb]

I suspect this will fail tests in some of the older eslint/node versions we continue to support.

[bmish]

I suspect this will fail tests in some of the older eslint/node versions we continue to support.

Isn't that why we're using ||?

"eslint-plugin-eslint-plugin": "^2.3.0 || ^3.5.3 || ^4.0.1", 

[ljharb]

That just allows it to be installed. I’m referring to relying on these functions being available on source code instead of context.

[codecov-commenter]

Codecov Report

Merging #3105 (6275be9) into master (210865e) will increase coverage by 0.00%.
The diff coverage is 71.42%.

@@ Coverage Diff @@ ## master #3105 +/- ## ======================================= Coverage 97.55% 97.55% ======================================= Files 118 118 Lines 7855 7857 +2 Branches 2801 2803 +2 ======================================= + Hits 7663 7665 +2  Misses 192 192 

Impacted Files	Coverage Δ
lib/rules/jsx-sort-default-props.js	84.05% <0.00%> (ø)
lib/rules/jsx-curly-spacing.js	94.11% <66.66%> (ø)
lib/rules/forbid-prop-types.js	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 210865e...6275be9. Read the comment docs.