Skip to content

Conversation

denis-sokolov
Copy link
Contributor

The heading of the section says “difference”, yet most of the rows have no difference, leading to a confusion.

Alternative implementation of #779.

Related: #238.

@codecov
Copy link

codecov bot commented Apr 6, 2021

Codecov Report

Merging #786 (5aa8db9) into master (df3c7ad) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@ ## master #786 +/- ## ======================================= Coverage 99.24% 99.24% ======================================= Files 98 98 Lines 1453 1453 Branches 477 477 ======================================= Hits 1442 1442 Misses 11 11 

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df3c7ad...5aa8db9. Read the comment docs.

@ljharb
Copy link
Member

ljharb commented Apr 6, 2021

The difference is the entire table; it’s not referring to individual rows.

Copy link
Collaborator

@jessebeach jessebeach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine.

@jessebeach jessebeach merged commit 6b9e89f into jsx-eslint:master Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants