Note that we may remove "dependencies" #401
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This was discussed in the if/then/else issue. There was significant support for removing "dependencies" as it is more straightforward, although sometimes more verbose, to implement the same funcitonality with if/then/else. Rather than going straight to ripping it out, let's give if/then/else a bit of time to gather feedback. Make a note of it to warn that "dependencies" may be removed, which will hopefully provoke some feedback on that idea as well.
dlax approved these changes Sep 11, 2017
gregsdennis added clarification Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This was discussed in the if/then/else issue. There was significant
support for removing "dependencies" as it is more straightforward,
although sometimes more verbose, to implement the same funcitonality
with if/then/else.
Rather than going straight to ripping it out, let's give if/then/else
a bit of time to gather feedback. Make a note of it to warn that
"dependencies" may be removed, which will hopefully provoke some
feedback on that idea as well.