add implicit reference string schemas #1432
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
moander reviewed Aug 30, 2023
moander reviewed Aug 31, 2023
gregsdennis force-pushed the gregsdennis/implicit-refs branch from 3a5b703 to e8a81bf Compare gregsdennis force-pushed the gregsdennis/implicit-refs branch from 8ba7252 to 97f7528 Compare Member Author
| I need to rework this as a proposal. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This is just a concept PR to get an idea of what #1078 might look like.
I'm not too particular on the wording of the new core spec section, but it's interesting to see the effect on the meta-schemas. It definitely eliminates the cruft of having to wrap every reference in
{ "$ref": ... }.There is an argument to be made about readability, but I'm sure it's just a matter of getting used to seeing it (like boolean schemas was).