Track the xml2rfc dependency using a requirements.txt file #1260
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| A bonus addition as part of the CI-revival work. To make sure we all (including CI) run on the same version of |
Julian reviewed Jul 21, 2022
The standard practice for tracking dependencies on Python projects is to declare the dependencies and the expected versions on a `requirements.txt` file that is read by `pip`. Right now, we request people to manually install the latest version of `xml2rfc`. After this commit, we properly track `xml2rfc` on `requirements.txt` and tweak the documentation a bit to show users how to install it from there instead. Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
Julian approved these changes Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
The standard practice for tracking dependencies on Python projects is to
declare the dependencies and the expected versions on a
requirements.txtfile that is read bypip.Right now, we request people to manually install the latest version of
xml2rfc. After this commit, we properly trackxml2rfconrequirements.txtand tweak the documentation a bit to show users howto install it from there instead.
Signed-off-by: Juan Cruz Viotti jv@jviotti.com