s/resolution scope/base URI/ #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| these changes look good to me. |
handrews added a commit that referenced this pull request Nov 7, 2017
Better explanation of the concerns around and possible future direction of $schema usage. Also add an XML comment to remind us of the most notable concern, so we can skip the whole thing where we forget about it and then argue about it until we work it out again. Which of course has never happened...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
So let's try making a pull request to the draft.
Not to push things along faster than they must, of course, let's be sure of the PR model we want to use before merging.
This fixes a number of vocabulary confusion, and inconsistencies with the URI definitions and ABNF terms. I think there's still a few more, though.