Skip to content

Conversation

@legoktm
Copy link
Contributor

@legoktm legoktm commented Apr 6, 2015

tox makes testing extremely easy, see https://tox.readthedocs.org/en/latest/
for more details.

Converted .travis.yml to use it.

tox makes testing extremely easy, see <https://tox.readthedocs.org/en/latest/> for more details. Converted .travis.yml to use it.
@Julian
Copy link
Member

Julian commented Apr 6, 2015

tox doesn't add much when you're not testing multiple versions, and comes with its own set of pitfalls. It also doesn't interact well with travis (mostly only when you're testing multiple versions).

I'm not against this change, but I'm "meh" about it. Letting it stew for a tiny bit to see how I feel in the morning :)?

@legoktm
Copy link
Contributor Author

legoktm commented Apr 7, 2015

I mainly find tox useful because it creates a standardized way to run tests. I don't need to remember the specific command to run tests for whatever project I'm working on, I can just run tox and know that the appropriate tests are being run.

@Julian
Copy link
Member

Julian commented Apr 7, 2015

I tend to much prefer that testrunner package is that uniform interface, but since this isn't a normal package obviously, it might make sense here I guess.

@Julian Julian merged commit d14cf96 into json-schema-org:develop Jul 25, 2015
@Julian
Copy link
Member

Julian commented Jul 25, 2015

Sorry that this sat here but I guess I'm OK with it, so merged :) Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants