Skip to content

Conversation

@mpalmer
Copy link

@mpalmer mpalmer commented Sep 21, 2014

Nothing particularly interesting or exciting, but it does mean that I can get a quick indication of whether my changes to the json-schema gem I'm working on actually do what they should.

@Julian
Copy link
Member

Julian commented Sep 21, 2014

I know essentially nothing about the hyper-schema, but from what I can tell, these tests are basically meta schema tests, which means they're sort of redundant doesn't it? If your validator passes all of the tests in the rest of the suite, then all of these tests are accomplished by just running your validator on your hyper schema with the meta-hyper-schema as the schema. AIUI the hyper-schema doesn't actually define any additional validation behavior. Is that correct?

@geraintluff care to chime in?

@mpalmer
Copy link
Author

mpalmer commented Sep 21, 2014

They would certainly be redundant if hyper-schema declared itself to use the base schema. As it stands, however, hyper-schema is entirely its own thing, according to its schema declaration.

@geraintluff
Copy link
Contributor

These tests look like they're testing whether the hyper-meta-schema correctly describes the structure of links/readOnly/media.

While this is useful, this is a test of the meta-schemas themselves, and not so much of a given validator.

Unless I'm missing something?

@geraintluff
Copy link
Contributor

Actual hyper-schema tests might be a good idea - but instead of testing validation using the hyper-meta-schema (which, as Julian says, seems redundant if validation in general works), hyper-schema tests would test things like media-type/link inference and read-only status.

@Julian Julian closed this Nov 27, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants