Skip to content

Enhance the select field with null value support #294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: development
Choose a base branch
from
Open

Enhance the select field with null value support #294

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1dfa6c3
Enhance the select field with null value support
ulion Mar 11, 2015
34c9c29
Do not change titleMap order if null value in it.
ulion Mar 20, 2015
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Do not change titleMap order if null value in it.
  • Loading branch information
@ulion
ulion committed Mar 20, 2015
commit 34c9c29fb56cdd98f891b35fa000e4e3c6841d0f
16 changes: 7 additions & 9 deletions src/services/schema-form.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -359,18 +359,16 @@ angular.module('schemaForm').provider('schemaForm',
}
}

if (obj.type === 'select' && obj.titleMap && obj.allowAutoNullOption !== false) {
// when allowNull === false, we leave titleMap as it is.
// else we filter out the null value and setup allowNull to the label
// so the select template will behaviour different according to it.
obj.titleMap = obj.titleMap.filter(function(item) {
if (obj.type === 'select' && obj.titleMap) {
// we check whether null value is in titleMap. if so, we fix possible null
// label and set allowAutoNullOption to false, then leave the titleMap as it is
obj.titleMap.forEach(function(item) {
if (item.value === null) {
// so we have null value option, setup the label and make it always selectable.
if (obj.allowAutoNullOption === undefined)
obj.allowAutoNullOption = item.name === null ? '' : item.name;
return false;
obj.allowAutoNullOption = false;
if (item.name === null)
item.name = '';
}
return true;
});
}

Expand Down